Skip to content

Fix make generate and run go-makefile-maker - #387

Merged
fwiesel merged 2 commits into
mainfrom
fix-makefile-generate
Nov 10, 2026
Merged

fwiesel merged 2 commits into
mainfrom
fix-makefile-generate

Conversation

@fwiesel

@fwiesel fwiesel commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

make generate — and with it the pre-commit make check hook — fails since the last go-makefile-maker run: the configured RBAC role name is embedded into the Makefile verbatim, without the quoting the invocation needs.

The quoting now lives in the configured value itself, so regenerations keep a working Makefile. The second commit runs go-makefile-maker to update the autogenerated workflows.

A go-makefile-maker run dropped the quoting around the release-scoped
ClusterRole name, breaking make generate and the pre-commit make check
hook. The quoting now lives in the configured value itself, so future
regenerations keep a working Makefile.

Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
@fwiesel
fwiesel force-pushed the fix-makefile-generate branch from b240479 to 0cf45f3 Compare November 9, 2026 14:26
@fwiesel fwiesel changed the title Fix make generate for the Helm-templated RBAC role name Fix make generate and run go-makefile-maker Nov 9, 2026
@fwiesel
fwiesel merged commit 060996a into main Nov 10, 2026
16 checks passed
@fwiesel
fwiesel deleted the fix-makefile-generate branch November 10, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants